This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
HC-58: Fix Problems Scheduling Unlimited Resources #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug injected on CiviCRM v4.7.19 caused chained API calls using '$value.' to
chain values to previous call to be interpreted as operators with syntax:
array('OP' => $val). This only happened if the first parameter for the chained
API call uses '$value.'.
Fixed by implementing civicrm_apiWrappers hook to preprocess parameters array
to make sure the first parameter of a chained API call is is not a chained
value.
As what the implemented fix does is move chained values to the last position of the array, if all the parameters of the call are chained values, the problem would still present itself. Added check to verify if all values are chained and if so, added sequential flag with 0 value as parameter.
Cycle to check if values of a chained call were all chained was botched, as it was checking the whole array of parameters on each cycle, instead of each individual value.
…unnlimited-resources HC-58: Fix Problems Scheduling Unlimited Resources
MiyaNoctem
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Loading of options is done via a series of chained API calls, from Resource, to Resource Set, to Resource Set Options. A bug injected on CiviCRM v4.7.19 on PR civicrm/civicrm-core#10033, caused chained API calls using '$value.' to chain values to be interpreted as operators with syntax: array('OP' => $val) instead. This only happened if the first parameter for the chained API call uses '$value.'. The bug has been fixed on CiviCRM core and is set to be released on v4.7.28.
See PR #158.
Before
The fix for v4.7.19 to v4.7.27 needs to be merged into master to deploy production sites.
After
The fix is merged into master branch of CiviBooking to be deployed on production sites.